custom post types - PHP question: how to combine syntax?

could someone please tell me where the mistake is in my PHP code? My PHP knowledge is extremely rudimentary although I have tried it with .operators.logical.php :-D

"translated" it should mean something like:

• Single Post -> Show reading time: yes
• Custom Post Type "wpdmpro" -> Show reading time: no

The function for the reading time works per se, but not in the way I put it together concerning the combination with the CPT.

With my code the reading time is not shown - neither in the CPT nor in the normal single post:

//  Reading Time

if (function_exists('readingtime') )  if ( is_single() && !  'wpdmpro' == get_post_type() )  

{      
echo '<span class="text-sep text-sep-cat">/</span>';               
echo readingtime();
}

Thanks for your help.

could someone please tell me where the mistake is in my PHP code? My PHP knowledge is extremely rudimentary although I have tried it with http://php/manual/de/language.operators.logical.php :-D

"translated" it should mean something like:

• Single Post -> Show reading time: yes
• Custom Post Type "wpdmpro" -> Show reading time: no

The function for the reading time works per se, but not in the way I put it together concerning the combination with the CPT.

With my code the reading time is not shown - neither in the CPT nor in the normal single post:

//  Reading Time

if (function_exists('readingtime') )  if ( is_single() && !  'wpdmpro' == get_post_type() )  

{      
echo '<span class="text-sep text-sep-cat">/</span>';               
echo readingtime();
}

Thanks for your help.

• custom-post-types
• php
• functions
• comparison

Share Improve this question asked Feb 14, 2019 at 0:49 BeeCeeBeeCee 544 bronze badges

Add a comment  | 

1 Answer 1

Sorted by: Reset to default 2

This part is incorrect:

if ( is_single() && !  'wpdmpro' == get_post_type() )

That essentially means:

if ( is_single() && false == get_post_type() ) {

Which will never be true. To check if a value does not equal another value, use !==:

if ( is_single() && 'wpdmpro' !== get_post_type() )

Also, the way you've combined the two if statements is hard to read and prone to errors. Instead, just add the first statement as a condition to the one statement:

if ( function_exists('readingtime') && is_single() && 'wpdmpro' !== get_post_type() ) {      
    echo '<span class="text-sep text-sep-cat">/</span>';               
    echo readingtime();
}